Go client RepoListOpts: Deprecate sync argument

[runephilosof-karnovgroup]

Component

other

Describe the bug

RepoListOpts first argument is sync

woodpecker/woodpecker-go/woodpecker/client.go

Line 167 in e0ed1b3

func (c *client) RepoListOpts(sync, all bool) ([]*Repo, error) {

Which controls the argument flush, sent to the server

woodpecker/woodpecker-go/woodpecker/client.go

Line 169 in e0ed1b3

uri := fmt.Sprintf(pathRepos+"?flush=%v&all=%v", c.addr, sync, all)

However, the server only cares about the all argument and ignores the flush.

So deprecate the sync argument (by documenting it with a code comment?)

System Info

github.com/woodpecker-ci/woodpecker v1.0.0

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[runephilosof-karnovgroup]

flush was removed in 0970f35

[runephilosof-karnovgroup]

Remove the sync argument in v2.0