Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All button spinners are triggered #2234

Closed
5 tasks done
xoxys opened this issue Aug 17, 2023 · 0 comments · Fixed by #2333
Closed
5 tasks done

All button spinners are triggered #2234

xoxys opened this issue Aug 17, 2023 · 0 comments · Fixed by #2333
Labels
bug Something isn't working ui frontend related
Milestone
2.0.0

Comments

@xoxys
Copy link
Member

xoxys commented Aug 17, 2023

Component

web-ui

Describe the bug

If clicking a button, the spinners on all other buttons on the same view are triggered as well:

image

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-4d83ea0d"}

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@xoxys xoxys added bug Something isn't working ui frontend related labels Aug 17, 2023
@xoxys xoxys mentioned this issue Aug 27, 2023
Merged
@qwerty287 qwerty287 added this to the 1.1.0 milestone Aug 27, 2023
xoxys added a commit that referenced this issue Aug 27, 2023
@xoxys
Fix button loading spinner when activating repos (#2333)
c5240d8 
Fixes: #2234

There is no internal `repo.id` for not enabled repos. Use the remote
forge repo id instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui frontend related
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Fix button loading spinner when activating repos xoxys/woodpecker
2 participants
@xoxys @qwerty287