Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar can't be closed with the counter button #2570

Closed
5 tasks done
qwerty287 opened this issue Oct 11, 2023 · 2 comments · Fixed by #2772
Closed
5 tasks done

Sidebar can't be closed with the counter button #2570

qwerty287 opened this issue Oct 11, 2023 · 2 comments · Fixed by #2772
Labels
bug Something isn't working regression fix a bug that was not released yet ui frontend related
Milestone
2.0.0

Comments

@qwerty287
Copy link
Contributor

qwerty287 commented Oct 11, 2023 •
edited
Loading

Component

web-ui

Describe the bug

open the sidebar panel with the counter button (top right) -> try to close with the same button

System Info

latest main and https://ci.woodpecker-ci.org

Additional context

regression #2325

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@qwerty287 qwerty287 added bug Something isn't working ui frontend related regression fix a bug that was not released yet labels Oct 11, 2023
@qwerty287 qwerty287 added this to the 2.0.0 milestone Oct 14, 2023
@pat-s
Copy link
Contributor

pat-s commented Nov 4, 2023

@qwerty287 This is still in 2.0.0 - do you wanna still fix it, or should we move it out?

@qwerty287
Copy link
Contributor Author

I would like to fix it, but I tried and I couldn't fix it. So yes move to 2.1

@qwerty287 qwerty287 modified the milestones: 2.0.0, 2.1.0, 2.0.1 Nov 4, 2023
@anbraten anbraten mentioned this issue Nov 7, 2023
Merged
@qwerty287 qwerty287 modified the milestones: 2.0.1, 2.0.0 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression fix a bug that was not released yet ui frontend related
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Fix sidepanel not closable via button anbraten/woodpecker
2 participants
@pat-s @qwerty287