Close sidebar on outside clicks

[xoxys]

record.webm

[qwerty287]

I'm fine with this change, however, if we merge it, we should remove the logic that stores and restores the current state (e.g. setUserConfig('isPipelineFeedOpen', false);) because it's pretty useless if it's closed directly.

[xoxys]

What do you mean with closed directly? Clicking on the pipeline in the sidebar will not close the sidebar. Clicking outside will use the same method setUserConfig to change the user config, as clicking on the icon in the header does.

[qwerty287]

Yes, I mean to completely remove the serUserConfig that persists the state of the panel (open/closed) and instead always close by default and directly close when it's toggled. I.e. here:

woodpecker/web/src/compositions/usePipelineFeed.ts

Line 14 in b618acb

const isOpen = computed(() => userConfig.value.isPipelineFeedOpen && !!isAuthenticated);

Use a local variable instead of userConfig.value.isPipelineFeedOpen so that the state is not persisted anymore.

[xoxys]

I don't get why you want to remove this feature. Removing it from the user store entirely means reloading the page with a currently open sidebar breaks, and the sidebar is closed after the reload. Why not keep it, so users can still reload the page without closing the sidebar?

[qwerty287]

If you think that's still useful, we can keep it.
I just meant that because currently the sidebar somewhat uses an "always-open"-approach, but if you close it on outside click, this is not longer the case. Reloading is a valid usecase for it though.

[xoxys]

Ah, I think I get your point. Hmm, ok so the only remaining use case would be side reloads. I can remove the persistence, we can also close this PR if we think it's more valuable to be able to keep the sidebar open while browsing through the ui.

[qwerty287]

if we think it's more valuable to be able to keep the sidebar open while browsing through the ui

I don't really think this is more valuable, I'd prefer one closing on outside click (but I never really used the sidebar that often), but the only thing the sidebar currently covers and makes a bit unusable are docs currently (this will change with #2327 though). Wiht #2327 I definitely think it's better to close it on outside click.

[xoxys]

I never thought about the use-case of keeping the sidebar open all the time. Personally, I find it annoying that I had to use the icon in the header to close it. If the sidebar is important enough to keep it always open, I would prefer that the pipeline not overlay other content, but that's a personal preference.

[xoxys]

What's missing for this PR?