Confusing [bad_habit] Please set an event filter on all when branches message

[oliverpool]

Component

web-ui

Describe the bug

Initially reported on https://codeberg.org/Codeberg-CI/feedback/issues/170

When a when block has no event field, a [bad_habit] Please set an event filter on all when branches message warning is shown, introduced by #3222.

This is not really actionable for the user:

• no idea which part of the pipeline is faulty
• no much idea how to solve it.

System Info

source	"https://github.com/woodpecker-ci/woodpecker"
version	"2.4.1"

Additional context

Having the step involved would be nice (it is recorded, but not displayed).

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[zc-devs]

warning is shown

even though there is no "when" directive at all.

[anbraten]

If I am correct the idea was basically to encourage the user to add at least some kind of when filters as otherwise in the case we add more functionality like additional events the existing pipelines would also be triggered by those new events when updating.

I guess we can simply improve the message a bit and additionally show the workflow file it was detected in.