Lint for event filter and deprecate `exclude` #3222

qwerty287 · 2024-01-19T16:13:41Z

return bad habit error if no event filter is set
If this is applied, it's useless to allow excludes on events. Therefore, deprecate it together with includes which should be replaced by base.StringOrSlice later.

woodpecker-bot · 2024-01-19T16:21:26Z

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3222.surge.sh

6543

let me have a look into the discussion first ...

... as i told - discussions are a bad "representation" (for me), as i normaly dont get either a notice nore the current consensus from it

pipeline/errors/error.go

Co-authored-by: Anbraten <anton@ju60.de>

codecov · 2024-01-21T07:46:39Z

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (9e96c9c) 36.32% compared to head (f2a6119) 36.34%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
pipeline/frontend/yaml/linter/linter.go	43.07%	33 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
+ Coverage   36.32%   36.34%   +0.02%     
==========================================
  Files         224      224              
  Lines       14759    14821      +62     
==========================================
+ Hits         5361     5387      +26     
- Misses       9008     9042      +34     
- Partials      390      392       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/docs/91-migrations.md

anbraten · 2024-02-08T09:17:33Z

@6543 Did you had the chance to read the discussion?

6543 · 2024-02-08T16:09:54Z

Not realy ... and i dont get why we should remove exclude?

6543 · 2024-02-08T16:18:55Z

Thanks github ... i had a detailed text. I recap it in a tldr now:

When filter currently has AND, OR and NAND, to build all combinations.

removing exclude is removing NAND

There is a workaround: use eval; but we should not encurage long eval statements if the simple filters just work fine

6543

PS: mentioned dicsuccion does not argue at all why exclude justd be removed!

qwerty287 · 2024-02-08T16:20:17Z

It's only removed for event filter and there it's useless because you should set an event filter so adding new ones does not execute your workflow/steps on unexpected events.

6543 · 2024-02-08T16:33:43Z

Ah ok ... well i do use it ... looks like i have to migrate on repo.

Only for events is fine but the codecomment do not indicate that

qwerty287 · 2024-02-08T16:51:42Z

codecomment

What do you mean? PR description, commit message, comment in Go code or docs?
I'm happy to update if needed

docs/docs/91-migrations.md

pipeline/frontend/yaml/linter/linter.go

pipeline/frontend/yaml/linter/linter_test.go

6543 · 2024-02-10T11:05:59Z

fixed the "code comment" issue ...
... I only found one issue left - but it's a minor thing and if it's hard to fix it now we can let it open for later

## [2.4.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.4.0) - 2024-03-19 ### 🔒 Security - Improve security context handling [[#3482](#3482)] - fix(deps): update module github.com/moby/moby to v24.0.9+incompatible [[#3323](#3323)] ### ✨ Features - Cli setup command [[#3384](#3384)] - Add bitbucket datacenter (server) support [[#2503](#2503)] - Cli updater [[#3382](#3382)] ### 📚 Documentation - Delete docs for v0.15.x [[#3508](#3508)] - Add deployment plugin [[#3495](#3495)] - Bump follow-redirects and fix broken anchors [[#3488](#3488)] - fix: plugin doc page not found [[#3480](#3480)] - Documentation improvements [[#3376](#3376)] - fix(deps): update docs npm deps non-major [[#3455](#3455)] - Add "Sonatype Nexus" plugin [[#3446](#3446)] - Add blog post [[#3439](#3439)] - Add "Gradle Wrapper Validation" plugin [[#3435](#3435)] - Add blog post [[#3410](#3410)] - Extend core ideas documentation [[#3405](#3405)] - docs: fix contributions link [[#3363](#3363)] - Update/fix some docs [[#3359](#3359)] - chore(deps): update dependency marked to v12 [[#3325](#3325)] ### 🐛 Bug Fixes - Fix skip setup for some general cli commands [[#3498](#3498)] - Move generic agent flags to cmd/agent/core [[#3484](#3484)] - Fix usage of WOODPECKER_DATABASE_DATASOURCE_FILE [[#3404](#3404)] - Set pull-request id and labels on pr-closed event [[#3442](#3442)] - Update org name on login [[#3409](#3409)] - Do not alter secret key upper-/lowercase [[#3375](#3375)] - fix: can't run multiple services on k8s [[#3395](#3395)] - Fix agent polling [[#3378](#3378)] - Remove empty strings from slice before parsing agent config [[#3387](#3387)] - Set correct link for commit [[#3368](#3368)] - Fix schema links [[#3369](#3369)] - Fix correctly handle gitlab pr closed events [[#3362](#3362)] - fix: update schema event_enum to remove error warning when.event [[#3357](#3357)] - Fix version check on next [[#3340](#3340)] - Ignore gitlab merge request events without code changes [[#3338](#3338)] - Ignore gitlab push events without commits [[#3339](#3339)] - Consider gitlab inherited permissions [[#3308](#3308)] - fix: agent panic when node is terminated during step execution [[#3331](#3331)] ### 📈 Enhancement - Enable golangci linter gomnd [[#3171](#3171)] - Apply "grpcnotrace" go build tag [[#3448](#3448)] - Simplify store interfaces [[#3437](#3437)] - Deprecate alternative names on secrets [[#3406](#3406)] - Store workflows/steps for blocked pipeline [[#2757](#2757)] - Parse email from Gitea webhook [[#3420](#3420)] - Replace http types on forge interface [[#3374](#3374)] - Prevent agent deletion when it's still running tasks [[#3377](#3377)] - Refactor internal services [[#915](#915)] - Lint for event filter and deprecate `exclude` [[#3222](#3222)] - Allow editing all environment variables in pipeline popups [[#3314](#3314)] - Parse backend options in backend [[#3227](#3227)] - Make agent usable for external backends [[#3270](#3270)] - Add no branches text [[#3312](#3312)] - Add loading spinner to repo list [[#3310](#3310)] ### Misc - Post on mastodon when releasing a new version [[#3509](#3509)] - chore(deps): update dependency alpine_3_18/ca-certificates to v20240226 [[#3501](#3501)] - fix(deps): update module github.com/google/go-github/v59 to v60 [[#3493](#3493)] - fix(deps): update dependency @intlify/unplugin-vue-i18n to v3 [[#3492](#3492)] - chore(deps): update dependency vue-tsc to v2 [[#3491](#3491)] - chore(deps): update dependency eslint-config-airbnb-typescript to v18 [[#3490](#3490)] - chore(deps): update web npm deps non-major [[#3489](#3489)] - fix(deps): update golang (packages) [[#3486](#3486)] - fix(deps): update module google.golang.org/protobuf to v1.33.0 [security] [[#3487](#3487)] - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.22.1 [[#3476](#3476)] - chore(deps): update docker.io/golang docker tag to v1.22.1 [[#3475](#3475)] - Update prettier version [[#3471](#3471)] - chore(deps): update woodpeckerci/plugin-ready-release-go docker tag to v1.1.0 [[#3464](#3464)] - chore(deps): lock file maintenance [[#3465](#3465)] - chore(deps): update postgres docker tag to v16.2 [[#3461](#3461)] - chore(deps): update lycheeverse/lychee docker tag to v0.14.3 [[#3429](#3429)] - fix(deps): update golang (packages) [[#3430](#3430)] - More `when` filters [[#3407](#3407)] - Apply `documentation`/`ui` label to corresponding renovate updates [[#3400](#3400)] - chore(deps): update dependency eslint-plugin-simple-import-sort to v12 [[#3396](#3396)] - chore(deps): update typescript-eslint monorepo to v7 (major) [[#3397](#3397)] - fix(deps): update module github.com/google/go-github/v58 to v59 [[#3398](#3398)] - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.22.0 [[#3392](#3392)] - chore(deps): update docker.io/golang docker tag [[#3391](#3391)] - fix(deps): update golang (packages) [[#3393](#3393)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v3.1.0 [[#3394](#3394)] - Add link checking [[#3371](#3371)] - Apply `dependencies` label to all PRs [[#3358](#3358)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v3.0.1 [[#3324](#3324)] --------- Co-authored-by: 6543 <m.huber@kithara.com> Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

qwerty287 added 2 commits January 19, 2024 16:49

Lint for event filter and deprecate exclude

54ab328

Fix tests

213d821

qwerty287 added the enhancement improve existing features label Jan 19, 2024

qwerty287 requested a review from a team January 19, 2024 16:13

6543 requested changes Jan 19, 2024

View reviewed changes

anbraten reviewed Jan 19, 2024

View reviewed changes

pipeline/errors/error.go Outdated Show resolved Hide resolved

Update pipeline/errors/error.go

6cdbc83

Co-authored-by: Anbraten <anton@ju60.de>

qwerty287 added this to the 2.3.0 milestone Jan 20, 2024

qwerty287 added 2 commits January 21, 2024 08:29

swager

cdca672

Merge branch 'main' into lint-event

f70830c

pat-s modified the milestones: 2.3.0, 2.x.x Jan 30, 2024

anbraten approved these changes Feb 8, 2024

View reviewed changes

docs/docs/91-migrations.md Outdated Show resolved Hide resolved

Merge branch 'main' into lint-event

bef758f

qwerty287 requested a review from 6543 February 8, 2024 15:35

6543 requested changes Feb 8, 2024

View reviewed changes

qwerty287 modified the milestones: 2.x.x, 2.4.0 Feb 9, 2024

Merge branch 'main' into lint-event

5b7b1dd

6543 reviewed Feb 10, 2024

View reviewed changes

docs/docs/91-migrations.md Outdated Show resolved Hide resolved

Update docs/docs/91-migrations.md

2e634d9

6543 reviewed Feb 10, 2024

View reviewed changes

pipeline/frontend/yaml/linter/linter.go Outdated Show resolved Hide resolved

6543 reviewed Feb 10, 2024

View reviewed changes

pipeline/frontend/yaml/linter/linter.go Outdated Show resolved Hide resolved

Apply suggestions from code review

6880040

6543 reviewed Feb 10, 2024

View reviewed changes

pipeline/frontend/yaml/linter/linter_test.go Outdated Show resolved Hide resolved

fix codecomment

3509f11

Update error message

f2a6119

6543 approved these changes Feb 10, 2024

View reviewed changes

6543 merged commit f369d2c into woodpecker-ci:main Feb 10, 2024
8 checks passed

qwerty287 deleted the lint-event branch February 10, 2024 16:40

qwerty287 mentioned this pull request Feb 10, 2024

Deprecations tracker #2780

Open

woodpecker-bot mentioned this pull request Feb 9, 2024

🎉 Release 2.4.0 #3307

Merged

1 task

BrewTestBot mentioned this pull request Mar 19, 2024

woodpecker-cli 2.4.0 Homebrew/homebrew-core#166593

Merged

oliverpool mentioned this pull request Apr 11, 2024

Confusing [bad_habit] Please set an event filter on all when branches message #3607

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lint for event filter and deprecate `exclude` #3222

Lint for event filter and deprecate `exclude` #3222

qwerty287 commented Jan 19, 2024

woodpecker-bot commented Jan 19, 2024 •

edited

Loading

6543 left a comment •

edited

Loading

codecov bot commented Jan 21, 2024 •

edited

Loading

anbraten commented Feb 8, 2024

6543 commented Feb 8, 2024

6543 commented Feb 8, 2024

6543 left a comment

qwerty287 commented Feb 8, 2024

6543 commented Feb 8, 2024

qwerty287 commented Feb 8, 2024

6543 commented Feb 10, 2024

Lint for event filter and deprecate exclude #3222

Lint for event filter and deprecate exclude #3222

Conversation

qwerty287 commented Jan 19, 2024

woodpecker-bot commented Jan 19, 2024 • edited Loading

6543 left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 21, 2024 • edited Loading

Codecov Report

anbraten commented Feb 8, 2024

6543 commented Feb 8, 2024

6543 commented Feb 8, 2024

6543 left a comment

Choose a reason for hiding this comment

qwerty287 commented Feb 8, 2024

6543 commented Feb 8, 2024

qwerty287 commented Feb 8, 2024

6543 commented Feb 10, 2024

Lint for event filter and deprecate `exclude` #3222

Lint for event filter and deprecate `exclude` #3222

woodpecker-bot commented Jan 19, 2024 •

edited

Loading

6543 left a comment •

edited

Loading

codecov bot commented Jan 21, 2024 •

edited

Loading