Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide example of YAML override and extension #1184

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Hide example of YAML override and extension #1184

merged 4 commits into from
Sep 17, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 13, 2022 •
edited
Loading

see #1192 for more infos

@6543 6543 added the documentation docu & docs label Sep 13, 2022
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Sep 13, 2022 •
edited
Loading

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1184.surge.sh

@6543 6543 changed the title Fix example of YAML override and extension WIP: Fix example of YAML override and extension Sep 13, 2022
@6543
Copy link
Member Author

6543 commented Sep 13, 2022

we have to look into https://github.com/go-yaml/yaml if it does parse this correctly!

the fix of this pull was done by error reports from https://jsonformatter.org/yaml-parser

codeberg.org/6543/go-yaml2json does not support it, witch does utilize github.com/go-yaml/yaml, so it could potentially be an upstream issue

@6543
Copy link
Member Author

6543 commented Sep 15, 2022

yaml/yaml#35

@6543
Copy link
Member Author

6543 commented Sep 16, 2022

issue tracked at #1192 ... will disable example for now

@6543 6543 changed the title WIP: Fix example of YAML override and extension Fix example of YAML override and extension Sep 16, 2022
@6543 6543 requested a review from anbraten September 16, 2022 10:06
@6543 6543 changed the title Fix example of YAML override and extension Fix and Hide example of YAML override and extension Sep 16, 2022
@6543 6543 requested a review from a team September 16, 2022 15:05
@6543 6543 added this to the 1.0.0 milestone Sep 16, 2022
@anbraten anbraten changed the title Fix and Hide example of YAML override and extension Hide example of YAML override and extension Sep 17, 2022
@anbraten anbraten merged commit 531bdf5 into woodpecker-ci:master Sep 17, 2022
@6543 6543 deleted the fix-docs-advanced-yml branch September 17, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
documentation docu & docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @woodpecker-bot @anbraten