Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid service names for Kubernetes #1234

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Oct 5, 2022

closes #1232

@anbraten anbraten changed the title Fix invalid service names on Kubernetes #1232 Fix invalid service names for Kubernetes Oct 5, 2022
@anbraten anbraten added the bug Something isn't working label Oct 5, 2022
@anbraten anbraten added this to the 1.0.0 milestone Oct 5, 2022
@anbraten anbraten marked this pull request as ready for review October 5, 2022 05:52
@anbraten anbraten requested a review from 6543 October 5, 2022 10:45
@codecov-commenter
Copy link

Codecov Report

Base: 44.41% // Head: 44.41% // No change to project coverage 👍

Coverage data is based on head (8e6fc75) compared to base (da997fa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   44.41%   44.41%           
=======================================
  Files         133      133           
  Lines        9724     9724           
=======================================
  Hits         4319     4319           
  Misses       5154     5154           
  Partials      251      251           
Impacted Files Coverage Δ
pipeline/error.go 100.00% <ø> (ø)
pipeline/frontend/yaml/container.go 81.25% <ø> (ø)
server/shared/procBuilder.go 85.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543 6543 merged commit f133941 into woodpecker-ci:master Oct 5, 2022
@anbraten anbraten deleted the fix-k8s-names branch October 5, 2022 18:53
simmstein pushed a commit to simmstein/woodpecker that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid service name on Kubernetes
4 participants