Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable metrics access if no token is set (#1469) #1470

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Disable metrics access if no token is set (#1469) #1470

merged 2 commits into from
Dec 23, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Dec 9, 2022

backport of #1469

@anbraten anbraten added bug Something isn't working backport-done indicates that this pull has been backported and removed backport-done indicates that this pull has been backported labels Dec 9, 2022
@anbraten anbraten changed the title disable metrics if no token is set disable metrics access if no token is set Dec 9, 2022
@anbraten anbraten added this to the 0.15.6 milestone Dec 9, 2022
@anbraten anbraten added the server label Dec 9, 2022
@lafriks lafriks enabled auto-merge (squash) December 9, 2022 09:17
@gapodo
Copy link
Contributor

gapodo commented Dec 11, 2022

IMHO, this should be considered a breaking change (it changes default behavior and cannot be overridden currently)

@gapodo gapodo mentioned this pull request Dec 11, 2022
Closed
4 tasks
@6543 6543 added breaking will break existing installations if no manual action happens security labels Dec 21, 2022
@6543 6543 disabled auto-merge December 23, 2022 17:12
@6543 6543 merged commit 414df47 into woodpecker-ci:release/v0.15 Dec 23, 2022
@6543 6543 changed the title disable metrics access if no token is set Disable metrics access if no token is set (#1469) Dec 23, 2022
@winterqt
Copy link

winterqt commented Jan 3, 2023

Out of curiosity, anyone know why this pipeline failed for this commit? The next commit at this tag that actually ran pipelines succeeded, with no related changes, so...

@6543
Copy link
Member

6543 commented Jan 3, 2023

database was to slow to drop index before test did try to create new one

@woodpecker-ci woodpecker-ci locked as resolved and limited conversation to collaborators Jan 3, 2023
@anbraten anbraten deleted the fix-metrics-015 branch January 3, 2023 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens bug Something isn't working security server
Projects
None yet
Milestone
0.15.6
Development

Successfully merging this pull request may close these issues.
5 participants
@anbraten @gapodo @winterqt @6543 @lafriks