wip: render button as a tag (need feedback) #1602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1259
I've adjusted the button component to conditionally render the proper element given the props. I did run into one oddity. If you specify both the
:href="..."and:to="..."the Router Links will not work, hence the btnAttrs work around to avoid the issue.Additionally, this PR currently causes a recursive render because the Button component and the DOM button element share the same name, so if we conditionally render based on the string
buttonit tries to render the Button component and then we hit a max recursion limit. To resolve this we need to rename the button component.What should I rename it to?
BaseButtonwould be my suggestion, but I wanted some feedback for I make that big of a change.