Support path prefix #1714
Merged
Support path prefix #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1714.surge.sh |
6543
reviewed
Apr 29, 2023
6543
requested changes
Apr 29, 2023
6543
approved these changes
Apr 29, 2023
spantaleev
added a commit
to devture/com.devture.ansible.role.woodpecker_ci_server
that referenced
this pull request
Apr 29, 2023
Still not part of a tagged Woodpecker CI release. Preparing for the next one. Related to woodpecker-ci/woodpecker#1714
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1636
closes #1429
supersedes #1586
Uses a different approach: just take the index.html compiled by vite and replace the paths to js and other files using regex. This is not compatible with the dev proxy which is also the reason why we can't use go templates for this.