Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo gate protection #1969

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 10, 2023

  • clarify docs
  • don't block cron pipelines
  • run manual triggered pipelines right away

close #1340

@6543 6543 added the bug Something isn't working label Jul 10, 2023
@6543 6543 requested a review from a team July 10, 2023 16:18
@6543 6543 added this to the 1.0.0 milestone Jul 10, 2023
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 10, 2023

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1969.surge.sh

docs/docs/20-usage/71-project-settings.md Outdated Show resolved Hide resolved
docs/docs/20-usage/71-project-settings.md Outdated Show resolved Hide resolved
server/pipeline/gated.go Outdated Show resolved Hide resolved
Co-authored-by: Anbraten <anton@ju60.de>
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage: 45.37% and project coverage change: -0.24 ⚠️

Comparison is base (6c58e9d) 39.28% compared to head (88b2992) 39.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
- Coverage   39.28%   39.05%   -0.24%     
==========================================
  Files         177      179       +2     
  Lines       10734    10793      +59     
==========================================
- Hits         4217     4215       -2     
- Misses       6223     6282      +59     
- Partials      294      296       +2     
Impacted Files Coverage Δ
pipeline/backend/docker/convert.go 8.46% <0.00%> (-0.14%) ⬇️
pipeline/backend/docker/docker.go 0.00% <0.00%> (ø)
pipeline/backend/kubernetes/pod.go 0.00% <0.00%> (ø)
pipeline/frontend/yaml/compiler/convert.go 0.00% <0.00%> (ø)
pipeline/frontend/yaml/types/container.go 77.77% <0.00%> (ø)
server/model/pipeline.go 0.00% <ø> (ø)
server/model/step.go 0.00% <ø> (ø)
server/model/workflow.go 0.00% <ø> (ø)
server/pipeline/create.go 0.00% <0.00%> (ø)
server/pipeline/gated.go 0.00% <0.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543 6543 requested a review from anbraten July 11, 2023 13:16
@anbraten anbraten changed the title Fix Gate Repo Fix repo gate protection Jul 11, 2023
@6543 6543 merged commit e85eeb1 into woodpecker-ci:master Jul 11, 2023
@6543 6543 deleted the fix_docs_protected branch July 11, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants