Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Kubernetes Support #23

Closed
wants to merge 36 commits into from
Closed

Native Kubernetes Support #23

wants to merge 36 commits into from

Conversation

laszlocph
Copy link
Member

#9

@laszlocph laszlocph force-pushed the kube branch 4 times, most recently from 2d5fdfc to 31382a0 Compare April 26, 2019 09:09
@laszlocph laszlocph force-pushed the kube branch 2 times, most recently from e4d8d42 to 7376263 Compare April 28, 2019 19:37
@laszlocph
Outdated
a7da8ef
@laszlocph
Merge branch 'master' into kube
f59633f 
* master:
  Bump version
  Latest drone-ui with stars feature
@laszlocph laszlocph changed the title Native Kubernetes Support - WIP Native Kubernetes Support May 29, 2019
laszlocph added 5 commits July 1, 2019 12:33
@laszlocph
env file
b4f04e9
@laszlocph
Merge remote-tracking branch 'origin/master' into kube
ba8bf40 
* origin/master: (75 commits)
  Bump version
  More prometheus metrics, refactoring
  Bump version
  Test Pause/Resume
  Endpoint that blocks until there are running builds
  Pause/Resume queue
  Bump version
  Latest UI
  Persist intended URL through the OAuth flow
  Bump version
  Latest UI
  Fallback to default config. Allows incremental rollout of custom-path
  Task dependencies to survive restarts
  .drone.yml takes precedence over configured path. Allows incremental rollout
  Assign multiple pending tasks in one go
  Supporting skip_clone
  Tests are deadlocking, probably sensitive to wait length
  Latest UI, pipeline path configurable
  Pipeline path configurable
  Small refactor
  ...
@laszlocph
Fixing volumes
37d8f79
@laszlocph
Reenable tests
e2307c9
@laszlocph
Drone tag
cfd150c
@laszlocph
Copy link
Member Author

This feature is parked for now. The code is promising, but not finished up.

@laszlocph laszlocph closed this Oct 24, 2019
@karolinepauls
Copy link

Hi Laszlo, what remains to be done? How can others help?

@laszlocph
Copy link
Member Author

laszlocph commented Apr 24, 2020 •
edited
Loading

Hi Laszlo, what remains to be done? How can others help?

That's a good question. By now the master branch diverged quite much, so first, integrating them, then a great deal of testing required.

It was certainly a big bet and I failed to tie the loose ends. Most notably,

  • changes to the yaml format were required to allow for Kubernetes specific settings like resource limits. Was contemplating retrofit some some special Docker fields for this, but a unifying model was missing. So I just latched on a few fields on the existing model but I never made a decision.
  • the RWX volume support needed to be opinionated and I never validated my assumptions with any user. So standing full force behind the decision I need some clarity how users want to use it.

In the meantime I started using Woodpecker in a Docker in Docker setup on Kubernetes with success, so I think I should document that first in #108

But I could pick the native support up again, but for that I'd love to talk to some users who are interested in this and I can validate some of my assumptions and make a few more decisions.

@karolinepauls
Copy link

Maybe perfect is the enemy of good and you can just temporarily declare the unfinished parts as unstable.

Sadly, I ended up configuring a modern-ish Jenkins (gross), but I may end up trying Woodpecker if reintroducing Jenkins results in an uprising of devs.

@tendant
Copy link

tendant commented Dec 6, 2020

Also would love to see this feature merged, even just basic functionality for Kubernetes support will be great step forward. Others might be able to continue contributing.

@laszlocph
Copy link
Member Author

I'm going to salvage the core of this change and merge it.

@6543 6543 deleted the kube branch September 11, 2021 16:22
@6543 6543 restored the kube branch September 11, 2021 16:23
@6543 6543 mentioned this pull request Nov 27, 2021
Closed
@6543 6543 deleted the kube branch November 27, 2021 03:09
@anbraten anbraten mentioned this pull request Nov 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laszlocph @karolinepauls @tendant