Move skip-ci back in front of config fetching #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbraten
added
bug
|
Ah I saw it. |
anbraten
changed the title
|
Still not happy with this approach and a bit strange this got merged within hours without any discussion while others were blocked form months... However at least one way back to skip ci... |
|
I considder this a hotfix!!! |
|
a.k.a. workaround! |
It should stay in the current place. The code is independent of the config-compiler and should work with every compiler we implement in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip logic should be in a central place and not in the compiler as it also needs to work independent of the compiler.
reverts #2216
solves #2313