Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker credentials #2598

Closed
wants to merge 1 commit into from

Conversation

anbraten
Copy link
Member

No description provided.

@anbraten anbraten added the bug Something isn't working label Oct 16, 2023
@anbraten anbraten changed the title fix docker credentials and add prettier Fix docker credentials Oct 16, 2023
@anbraten

This comment was marked as resolved.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Oct 16, 2023

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2598.surge.sh

@@ -79,6 +77,8 @@ steps:
dockerfile: docker/Dockerfile.server.multiarch
platforms: *platforms_preview
tag: pull_${CI_COMMIT_PULL_REQUEST}
logins: *publish_logins
dry_run: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still run to publish test images of prs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if we should even publish them. It sometimes is a nice way to test it, but on the other hand its also a lot of spam and therefore rarely used. IMO developers with a IDE can also build the image on their own if really needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that. It's convenient though for some non-expert people which don't want to clone and push a PR image.

Maybe it could be somehow conditioned on a PR label? There is CI_COMMIT_PULL_REQUEST_LABELS and we could add a "when" condition to the step.

@pat-s
Copy link
Contributor

pat-s commented Oct 18, 2023

@anbraten Do you still want to merge this (WRT to the cleanups) or close?

qwerty287 added a commit that referenced this pull request Oct 23, 2023
- removes docker username secret
(#2589)
- fix `when` filters
https://ci.woodpecker-ci.org/repos/3780/pipeline/8907/9
- add path filter to only build docker image if stuff was changed (or
label is added)

closes #2203 
closes #2598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants