-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker credentials #2598
Fix docker credentials #2598
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2598.surge.sh |
693b635
to
f0df4ff
Compare
@@ -79,6 +77,8 @@ steps: | |||
dockerfile: docker/Dockerfile.server.multiarch | |||
platforms: *platforms_preview | |||
tag: pull_${CI_COMMIT_PULL_REQUEST} | |||
logins: *publish_logins | |||
dry_run: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this still run to publish test images of prs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure if we should even publish them. It sometimes is a nice way to test it, but on the other hand its also a lot of spam and therefore rarely used. IMO developers with a IDE can also build the image on their own if really needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that. It's convenient though for some non-expert people which don't want to clone and push a PR image.
Maybe it could be somehow conditioned on a PR label? There is CI_COMMIT_PULL_REQUEST_LABELS
and we could add a "when" condition to the step.
@anbraten Do you still want to merge this (WRT to the cleanups) or close? |
- removes docker username secret (#2589) - fix `when` filters https://ci.woodpecker-ci.org/repos/3780/pipeline/8907/9 - add path filter to only build docker image if stuff was changed (or label is added) closes #2203 closes #2598
No description provided.