Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save GOOS and GOARCH in local engine #2701

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Save GOOS and GOARCH in local engine #2701

merged 1 commit into from
Nov 2, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 2, 2023

make refactoring easyer

@6543
save GOOS and GOARCH in local engine
576baad 
make refactoring easyer
@6543 6543 added refactor delete or replace old code skip-changelog backend/local labels Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (de53b90) 33.68% compared to head (576baad) 33.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   33.68%   33.67%   -0.01%     
==========================================
  Files         212      212              
  Lines       13536    13539       +3     
==========================================
  Hits         4559     4559              
- Misses       8625     8628       +3     
  Partials      352      352
Files Coverage Δ
pipeline/backend/local/local.go 0.00% <0.00%> (ø)
pipeline/backend/local/clone.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit c750689 into woodpecker-ci:main Nov 2, 2023
@anbraten anbraten changed the title save GOOS and GOARCH in local engine Save GOOS and GOARCH in local engine Nov 2, 2023
@6543 6543 deleted the local_backend/get-info-from-runtime-once branch November 2, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
backend/local refactor delete or replace old code skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @qwerty287