Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pipeline errors using pagination #2735

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Nov 4, 2023

closes #2737

@anbraten anbraten added bug Something isn't working regression fix a bug that was not released yet labels Nov 4, 2023
@anbraten anbraten marked this pull request as draft November 4, 2023 14:28
@anbraten anbraten added the build_pr_images If set, the CI will build images for this PR and push to Dockerhub label Nov 4, 2023
@anbraten anbraten added this to the 2.0.0 milestone Nov 4, 2023
@anbraten anbraten marked this pull request as ready for review November 6, 2023 08:34
@qwerty287
Copy link
Contributor

Does this fix #2737?

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (45a5a2d) 34.02% compared to head (7c2f4c4) 34.02%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   34.02%   34.02%   -0.01%     
==========================================
  Files         214      214              
  Lines       13735    13777      +42     
==========================================
+ Hits         4674     4688      +14     
- Misses       8694     8717      +23     
- Partials      367      372       +5     
Files Coverage Δ
pipeline/frontend/yaml/compiler/convert.go 62.94% <60.00%> (+1.63%) ⬆️
pipeline/frontend/yaml/parse.go 66.03% <70.00%> (+2.40%) ⬆️
...ation/026_convert_to_new_pipeline_errors_format.go 68.75% <60.00%> (+8.75%) ⬆️
pipeline/frontend/yaml/compiler/compiler.go 39.59% <27.50%> (-5.66%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten
Copy link
Member Author

anbraten commented Nov 6, 2023

Does this fix #2737?

I hope so, but wanted to create test images first for the reporting users to check. On my deployment it worked from the beginning on.

@anbraten anbraten merged commit 731d471 into woodpecker-ci:main Nov 6, 2023
@anbraten anbraten deleted the fix-error-migration branch November 6, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build_pr_images If set, the CI will build images for this PR and push to Dockerhub regression fix a bug that was not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with DB migration convert-to-new-pipeline-error-format
3 participants