Migrate to github.com/urfave/cli/v3 #2951

6543 · 2023-12-14T19:04:44Z

No description provided.

6543 · 2024-02-21T19:34:56Z

Address #3419 with tis too ...

6543 · 2024-02-21T19:35:11Z

-> always prefer _FILE

anbraten · 2024-07-03T11:16:24Z

Quite impatient looking forward for the feature persistent flags options / free ordering of flags in v3: urfave/cli#1568 😅

cmd/agent/main.go

pipeline/backend/docker/docker.go

6543 · 2024-07-06T01:13:26Z

ok @anbraten I'm waiting for urfave/cli#1945 and if that's merged this here is as good as it can be

woodpecker-bot · 2024-07-13T20:47:34Z

Deployment of preview was torn down

codecov · 2024-07-13T20:53:37Z

Codecov Report

Attention: Patch coverage is 1.45985% with 270 lines in your changes missing coverage. Please review.

Project coverage is 26.82%. Comparing base (e393456) to head (2dc3606).

Files	Patch %	Lines
pipeline/rpc/proto/woodpecker_grpc.pb.go	0.00%	24 Missing ⚠️
cli/internal/config/config.go	0.00%	20 Missing ⚠️
cli/exec/exec.go	0.00%	16 Missing ⚠️
cli/exec/metadata.go	0.00%	12 Missing ⚠️
cmd/server/setup.go	0.00%	10 Missing ⚠️
cli/common/hooks.go	0.00%	7 Missing ⚠️
cli/common/pipeline.go	0.00%	5 Missing ⚠️
cli/lint/lint.go	0.00%	5 Missing ⚠️
cmd/server/main.go	0.00%	5 Missing ⚠️
cli/cron/cron_add.go	0.00%	4 Missing ⚠️
... and 75 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
- Coverage   26.84%   26.82%   -0.02%     
==========================================
  Files         393      393              
  Lines       27410    27427      +17     
==========================================
  Hits         7357     7357              
- Misses      19352    19369      +17     
  Partials      701      701

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

6543 · 2024-07-13T21:00:24Z

It's done ... just need to wait for the split out pulls to be merged first

lafriks

Small nit but otherwise lgtm

pipeline/backend/types/config.go

Co-authored-by: Lauris BH <lauris@nix.lv>

## [2.7.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.7.0) - 2024-07-18 ### 🔒 Security - Add blocklist of environment variables who could alter execution of plugins [[#3934](#3934)] - Make sure plugins only mount the workspace base in a predefinde location [[#3933](#3933)] - Disallow to set arbitrary environments for plugins [[#3909](#3909)] - Use proper oauth state [[#3847](#3847)] - Enhance token checking [[#3842](#3842)] - Bump github.com/hashicorp/go-retryablehttp v0.7.5 -> v0.7.7 [[#3834](#3834)] ### ✨ Features - Gracefully shutdown server [[#3896](#3896)] - Gracefully shutdown agent [[#3895](#3895)] - Convert urls in logs to links [[#3904](#3904)] - Allow login using multiple forges [[#3822](#3822)] - Global and organization registries [[#1672](#1672)] - Cli get repo from git remote [[#3830](#3830)] - Add api for forges [[#3733](#3733)] ### 📈 Enhancement - Cli fix pipeline logs [[#3913](#3913)] - Migrate to github.com/urfave/cli/v3 [[#2951](#2951)] - Allow to change the working directory also for plugins and services [[#3914](#3914)] - Remove `unplugin-icons` [[#3809](#3809)] - Release windows binaries as zip file [[#3906](#3906)] - Convert to openapi 3.0 [[#3897](#3897)] - Enhance pipeline list [[#3898](#3898)] - Add user registries UI [[#3888](#3888)] - Sort users by login [[#3891](#3891)] - Exclude dummy backend in production [[#3877](#3877)] - Fix deploy task env [[#3878](#3878)] - Get default branch and show message in pipeline list [[#3867](#3867)] - Add timestamp for last work done by agent [[#3844](#3844)] - Adjust logger types [[#3859](#3859)] - Cleanup state reporting [[#3850](#3850)] - Unify DB tables/columns [[#3806](#3806)] - Let webhook pass on pipeline parsing error [[#3829](#3829)] - Exclude mocks from release build [[#3831](#3831)] - K8s secrets reference from step [[#3655](#3655)] ### 🐛 Bug Fixes - Handle empty repositories in gitea when listing PRs [[#3925](#3925)] - Update alpine package dep for docker images [[#3917](#3917)] - Don't report error if agent was terminated gracefully [[#3894](#3894)] - Let agents continuously report their health [[#3893](#3893)] - Ignore warnings for cli exec [[#3868](#3868)] - Correct favicon states [[#3832](#3832)] - Cleanup of the login flow and tests [[#3810](#3810)] - Fix newlines in logs [[#3808](#3808)] - Fix authentication error handling [[#3807](#3807)] ### 📚 Documentation - Streamline docs for new users [[#3803](#3803)] - Add mastodon verification [[#3843](#3843)] - chore(deps): update docs npm deps non-major [[#3837](#3837)] - fix(deps): update docs npm deps non-major [[#3824](#3824)] - Add openSUSE package [[#3800](#3800)] - chore(deps): update docs npm deps non-major [[#3798](#3798)] - Add "Docker Tags" Plugin [[#3796](#3796)] - chore(deps): update dependency marked to v13 [[#3792](#3792)] - chore: fix some comments [[#3788](#3788)] ### Misc - chore(deps): update web npm deps non-major [[#3930](#3930)] - chore(deps): update dependency vitest to v2 [[#3905](#3905)] - fix(deps): update module github.com/google/go-github/v62 to v63 [[#3910](#3910)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v4.1.0 [[#3908](#3908)] - Update plugin-git and add renovate trigger [[#3901](#3901)] - chore(deps): update docker.io/mstruebing/editorconfig-checker docker tag to v3.0.3 [[#3903](#3903)] - fix(deps): update golang-packages [[#3875](#3875)] - chore(deps): lock file maintenance [[#3876](#3876)] - [pre-commit.ci] pre-commit autoupdate [[#3862](#3862)] - Add dummy backend [[#3820](#3820)] - chore(deps): update dependency replace-in-file to v8 [[#3852](#3852)] - Update forgejo sdk [[#3840](#3840)] - chore(deps): lock file maintenance [[#3838](#3838)] - Allow to set dist dir using env var [[#3814](#3814)] - chore(deps): lock file maintenance [[#3805](#3805)] - chore(deps): update docker.io/lycheeverse/lychee docker tag to v0.15.1 [[#3797](#3797)]

The agent should continue to report the health status as long as it got not terminated. extracted from woodpecker-ci#2951 Right now there exist the case where you have ''shadow agents" who pull tasks even if they don't report healthy...

## [2.7.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.7.0) - 2024-07-18 ### 🔒 Security - Add blocklist of environment variables who could alter execution of plugins [[woodpecker-ci#3934](woodpecker-ci#3934)] - Make sure plugins only mount the workspace base in a predefinde location [[woodpecker-ci#3933](woodpecker-ci#3933)] - Disallow to set arbitrary environments for plugins [[woodpecker-ci#3909](woodpecker-ci#3909)] - Use proper oauth state [[woodpecker-ci#3847](woodpecker-ci#3847)] - Enhance token checking [[woodpecker-ci#3842](woodpecker-ci#3842)] - Bump github.com/hashicorp/go-retryablehttp v0.7.5 -> v0.7.7 [[woodpecker-ci#3834](woodpecker-ci#3834)] ### ✨ Features - Gracefully shutdown server [[woodpecker-ci#3896](woodpecker-ci#3896)] - Gracefully shutdown agent [[woodpecker-ci#3895](woodpecker-ci#3895)] - Convert urls in logs to links [[woodpecker-ci#3904](woodpecker-ci#3904)] - Allow login using multiple forges [[woodpecker-ci#3822](woodpecker-ci#3822)] - Global and organization registries [[woodpecker-ci#1672](woodpecker-ci#1672)] - Cli get repo from git remote [[woodpecker-ci#3830](woodpecker-ci#3830)] - Add api for forges [[woodpecker-ci#3733](woodpecker-ci#3733)] ### 📈 Enhancement - Cli fix pipeline logs [[woodpecker-ci#3913](woodpecker-ci#3913)] - Migrate to github.com/urfave/cli/v3 [[woodpecker-ci#2951](woodpecker-ci#2951)] - Allow to change the working directory also for plugins and services [[woodpecker-ci#3914](woodpecker-ci#3914)] - Remove `unplugin-icons` [[woodpecker-ci#3809](woodpecker-ci#3809)] - Release windows binaries as zip file [[woodpecker-ci#3906](woodpecker-ci#3906)] - Convert to openapi 3.0 [[woodpecker-ci#3897](woodpecker-ci#3897)] - Enhance pipeline list [[woodpecker-ci#3898](woodpecker-ci#3898)] - Add user registries UI [[woodpecker-ci#3888](woodpecker-ci#3888)] - Sort users by login [[woodpecker-ci#3891](woodpecker-ci#3891)] - Exclude dummy backend in production [[woodpecker-ci#3877](woodpecker-ci#3877)] - Fix deploy task env [[woodpecker-ci#3878](woodpecker-ci#3878)] - Get default branch and show message in pipeline list [[woodpecker-ci#3867](woodpecker-ci#3867)] - Add timestamp for last work done by agent [[woodpecker-ci#3844](woodpecker-ci#3844)] - Adjust logger types [[woodpecker-ci#3859](woodpecker-ci#3859)] - Cleanup state reporting [[woodpecker-ci#3850](woodpecker-ci#3850)] - Unify DB tables/columns [[woodpecker-ci#3806](woodpecker-ci#3806)] - Let webhook pass on pipeline parsing error [[woodpecker-ci#3829](woodpecker-ci#3829)] - Exclude mocks from release build [[woodpecker-ci#3831](woodpecker-ci#3831)] - K8s secrets reference from step [[woodpecker-ci#3655](woodpecker-ci#3655)] ### 🐛 Bug Fixes - Handle empty repositories in gitea when listing PRs [[woodpecker-ci#3925](woodpecker-ci#3925)] - Update alpine package dep for docker images [[woodpecker-ci#3917](woodpecker-ci#3917)] - Don't report error if agent was terminated gracefully [[woodpecker-ci#3894](woodpecker-ci#3894)] - Let agents continuously report their health [[woodpecker-ci#3893](woodpecker-ci#3893)] - Ignore warnings for cli exec [[woodpecker-ci#3868](woodpecker-ci#3868)] - Correct favicon states [[woodpecker-ci#3832](woodpecker-ci#3832)] - Cleanup of the login flow and tests [[woodpecker-ci#3810](woodpecker-ci#3810)] - Fix newlines in logs [[woodpecker-ci#3808](woodpecker-ci#3808)] - Fix authentication error handling [[woodpecker-ci#3807](woodpecker-ci#3807)] ### 📚 Documentation - Streamline docs for new users [[woodpecker-ci#3803](woodpecker-ci#3803)] - Add mastodon verification [[woodpecker-ci#3843](woodpecker-ci#3843)] - chore(deps): update docs npm deps non-major [[woodpecker-ci#3837](woodpecker-ci#3837)] - fix(deps): update docs npm deps non-major [[woodpecker-ci#3824](woodpecker-ci#3824)] - Add openSUSE package [[woodpecker-ci#3800](woodpecker-ci#3800)] - chore(deps): update docs npm deps non-major [[woodpecker-ci#3798](woodpecker-ci#3798)] - Add "Docker Tags" Plugin [[woodpecker-ci#3796](woodpecker-ci#3796)] - chore(deps): update dependency marked to v13 [[woodpecker-ci#3792](woodpecker-ci#3792)] - chore: fix some comments [[woodpecker-ci#3788](woodpecker-ci#3788)] ### Misc - chore(deps): update web npm deps non-major [[woodpecker-ci#3930](woodpecker-ci#3930)] - chore(deps): update dependency vitest to v2 [[woodpecker-ci#3905](woodpecker-ci#3905)] - fix(deps): update module github.com/google/go-github/v62 to v63 [[woodpecker-ci#3910](woodpecker-ci#3910)] - chore(deps): update docker.io/woodpeckerci/plugin-docker-buildx docker tag to v4.1.0 [[woodpecker-ci#3908](woodpecker-ci#3908)] - Update plugin-git and add renovate trigger [[woodpecker-ci#3901](woodpecker-ci#3901)] - chore(deps): update docker.io/mstruebing/editorconfig-checker docker tag to v3.0.3 [[woodpecker-ci#3903](woodpecker-ci#3903)] - fix(deps): update golang-packages [[woodpecker-ci#3875](woodpecker-ci#3875)] - chore(deps): lock file maintenance [[woodpecker-ci#3876](woodpecker-ci#3876)] - [pre-commit.ci] pre-commit autoupdate [[woodpecker-ci#3862](woodpecker-ci#3862)] - Add dummy backend [[woodpecker-ci#3820](woodpecker-ci#3820)] - chore(deps): update dependency replace-in-file to v8 [[woodpecker-ci#3852](woodpecker-ci#3852)] - Update forgejo sdk [[woodpecker-ci#3840](woodpecker-ci#3840)] - chore(deps): lock file maintenance [[woodpecker-ci#3838](woodpecker-ci#3838)] - Allow to set dist dir using env var [[woodpecker-ci#3814](woodpecker-ci#3814)] - chore(deps): lock file maintenance [[woodpecker-ci#3805](woodpecker-ci#3805)] - chore(deps): update docker.io/lycheeverse/lychee docker tag to v0.15.1 [[woodpecker-ci#3797](woodpecker-ci#3797)]

6543 added 2 commits December 14, 2023 19:36

switch to github.com/urfave/cli/v3

a639f4d

migration first round

60066ce

6543 added enhancement improve existing features dependencies labels Dec 14, 2023

6543 added 3 commits December 14, 2023 20:20

next

523e89b

next

02c8fd3

done beside TODO

c82a6a5

qwerty287 changed the title ~~WIP: migrateo to github.com/urfave/cli/v3~~ WIP: migrate to github.com/urfave/cli/v3 Dec 16, 2023

6543 added 12 commits July 6, 2024 01:36

Merge branch 'main' into urfave/cli/v3

533521b

fix things

cbe5c30

get cli kinda working

1f1c95b

Merge branch 'main' into urfave/cli/v3

ede4b6b

jup

2f46d24

make urfave/cli#1945 afailable

bbeae1c

server build

21b7845

fix name

b96fb27

fix name (2)

fad0d0f

fix lint err

575ef09

use new cli interfaces

f407175

move context creation stack up

14d980a

6543 commented Jul 6, 2024

View reviewed changes

cmd/agent/main.go Outdated Show resolved Hide resolved

use new cli interface

eea7c69

6543 commented Jul 6, 2024

View reviewed changes

pipeline/backend/docker/docker.go Outdated Show resolved Hide resolved

rename CliContext to CliCommand

29da6c1

6543 mentioned this pull request Jul 6, 2024

Add File() urfave/cli#1945

Merged

Merge branch 'main' into urfave/cli/v3

8460d99

i know what i do

6c8af69

6543 mentioned this pull request Jul 13, 2024

V3 has no app.ToMarkdown() urfave/cli#1955

Closed

6543 added 2 commits July 13, 2024 21:08

jup

8adc67e

Merge branch 'main' into urfave/cli/v3

2463e6d

6543 changed the title ~~WIP: migrate to github.com/urfave/cli/v3~~ Migrate to github.com/urfave/cli/v3 Jul 13, 2024

6543 added the blocked It's ready but something external is blocking it label Jul 13, 2024

6543 marked this pull request as ready for review July 13, 2024 20:59

6543 added 2 commits July 14, 2024 02:05

Merge branch 'main' into urfave/cli/v3

3fd1da5

we have the context created earlyer now

003b8d9

6543 requested a review from a team July 14, 2024 00:17

6543 removed the blocked It's ready but something external is blocking it label Jul 16, 2024

6543 added 2 commits July 16, 2024 19:42

Merge branch 'main' into urfave/cli/v3

058f28b

update deps

ad2b91a

6543 requested a review from anbraten July 16, 2024 17:47

Merge branch 'main' into urfave/cli/v3

33a91d7

lafriks approved these changes Jul 17, 2024

View reviewed changes

pipeline/backend/types/config.go Outdated Show resolved Hide resolved

6543 and others added 2 commits July 18, 2024 01:03

Update pipeline/backend/types/config.go

fe4aba2

Co-authored-by: Lauris BH <lauris@nix.lv>

Merge branch 'main' into urfave/cli/v3

2dc3606

6543 merged commit cd5f6f7 into woodpecker-ci:main Jul 17, 2024
7 of 9 checks passed

6543 deleted the urfave/cli/v3 branch July 17, 2024 23:26

woodpecker-bot mentioned this pull request Jul 18, 2024

🎉 Release 2.7.0 #3793

Merged

1 task

BrewTestBot mentioned this pull request Jul 18, 2024

woodpecker-cli 2.7.0 Homebrew/homebrew-core#177789

Merged

woodpecker-bot mentioned this pull request Jul 19, 2024

🎉 Release 3.0.0 #3938

Closed

1 task

6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024

Migrate to github.com/urfave/cli/v3 (woodpecker-ci#2951)

e036cc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to github.com/urfave/cli/v3 #2951

Migrate to github.com/urfave/cli/v3 #2951

6543 commented Dec 14, 2023 •

edited

Loading

6543 commented Feb 21, 2024

6543 commented Feb 21, 2024

anbraten commented Jul 3, 2024 •

edited

Loading

6543 commented Jul 6, 2024

woodpecker-bot commented Jul 13, 2024 •

edited

Loading

codecov bot commented Jul 13, 2024 •

edited

Loading

6543 commented Jul 13, 2024

lafriks left a comment

Migrate to github.com/urfave/cli/v3 #2951

Migrate to github.com/urfave/cli/v3 #2951

Conversation

6543 commented Dec 14, 2023 • edited Loading

6543 commented Feb 21, 2024

6543 commented Feb 21, 2024

anbraten commented Jul 3, 2024 • edited Loading

6543 commented Jul 6, 2024

woodpecker-bot commented Jul 13, 2024 • edited Loading

codecov bot commented Jul 13, 2024 • edited Loading

Codecov Report

6543 commented Jul 13, 2024

lafriks left a comment

Choose a reason for hiding this comment

6543 commented Dec 14, 2023 •

edited

Loading

anbraten commented Jul 3, 2024 •

edited

Loading

woodpecker-bot commented Jul 13, 2024 •

edited

Loading

codecov bot commented Jul 13, 2024 •

edited

Loading