Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing dependencies #3060

Closed
wants to merge 2 commits into from

Conversation

qwerty287
Copy link
Contributor

To fix issues with steps/workflows filtered by when.

@qwerty287 qwerty287 added the refactor delete or replace old code label Dec 29, 2023
@qwerty287 qwerty287 added this to the 2.2.0 milestone Dec 29, 2023
@qwerty287 qwerty287 requested a review from a team December 29, 2023 09:33
@anbraten
Copy link
Member

anbraten commented Dec 29, 2023

Shouldn't the depending step be required to have the same filter as well in which case it would not be an issue?

@qwerty287
Copy link
Contributor Author

Then our CI config has too many depends_on. I can also try to fix this.

@qwerty287 qwerty287 closed this Dec 29, 2023
@qwerty287 qwerty287 deleted the ignore-missing-step branch December 29, 2023 10:51
@lafriks
Copy link
Contributor

lafriks commented Dec 29, 2023

I still think this could be useful, maybe not in our pipeline but in general otherwise there might be cases where you could have to duplicate steps just to match conditions. Skipped steps imho should be treated as completed in DAG resolution

lafriks pushed a commit that referenced this pull request Dec 29, 2023
also close #3060 because it's no longer necessary then

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@qwerty287 qwerty287 removed this from the 2.2.0 milestone Dec 31, 2023
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
also close woodpecker-ci#3060 because it's no longer necessary then

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants