Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: remove step-id and add step-number as option to logs #3927

Merged
merged 3 commits into from
Jul 19, 2024
Merged

CLI: remove step-id and add step-number as option to logs #3927

merged 3 commits into from
Jul 19, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 18, 2024 •
edited
Loading

@6543 6543 added enhancement improve existing features breaking will break existing installations if no manual action happens blocked It's ready but something external is blocking it labels Jul 18, 2024
@6543 6543 added this to the 3.0.0 milestone Jul 18, 2024
This was referenced Jul 18, 2024
Merged
Open
@qwerty287 qwerty287 added the cli label Jul 18, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 18, 2024 •
edited
Loading

Deployment of preview was torn down

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 26.78%. Comparing base (1274de2) to head (a5312bf).
Report is 4 commits behind head on main.

Files Patch % Lines
cli/internal/util.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3927      +/-   ##
==========================================
- Coverage   26.83%   26.78%   -0.06%     
==========================================
  Files         393      393              
  Lines       27431    27475      +44     
==========================================
- Hits         7362     7358       -4     
- Misses      19368    19416      +48     
  Partials      701      701

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 removed the blocked It's ready but something external is blocking it label Jul 18, 2024
@6543 6543 requested a review from a team July 18, 2024 22:11
@6543 6543 merged commit 7903d6f into woodpecker-ci:main Jul 19, 2024
6 of 7 checks passed
@6543 6543 deleted the cli-use-step-PID-insteadOf-StepID branch July 19, 2024 07:29
This was referenced Jul 19, 2024
Closed
Closed
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@6543
CLI: remove step-id and add step-number as option to logs (woodpecker…
5b7cdd9 
…-ci#3927)
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens cli enhancement improve existing features
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @woodpecker-bot @qwerty287