Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WOODPECKER_DEV_OAUTH_HOST and WOODPECKER_DEV_GITEA_OAUTH_URL #3961

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 22, 2024

Removed WOODPECKER_DEV_OAUTH_HOST and WOODPECKER_DEV_GITEA_OAUTH_URL use WOODPECKER_EXPERT_FORGE_OAUTH_HOST

@6543 6543 added refactor delete or replace old code breaking will break existing installations if no manual action happens labels Jul 22, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 22, 2024

Deployment of preview was torn down

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.86%. Comparing base (d2b5e20) to head (9abd000).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3961      +/-   ##
==========================================
+ Coverage   26.84%   26.86%   +0.01%     
==========================================
  Files         394      394              
  Lines       27518    27518              
==========================================
+ Hits         7388     7393       +5     
+ Misses      19428    19423       -5     
  Partials      702      702              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 requested a review from a team July 22, 2024 20:03
@zc-devs
Copy link
Contributor

zc-devs commented Jul 23, 2024

Removed `WOODPECKER_DEV_OAUTH_HOST`
use     `WOODPECKER_DEV_OAUTH_HOST`

🤔

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was a bit too fast...

docs/docs/91-migrations.md Outdated Show resolved Hide resolved
cmd/server/flags.go Show resolved Hide resolved
6543 and others added 3 commits July 23, 2024 13:03
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@6543 6543 requested a review from qwerty287 July 23, 2024 11:44
@6543 6543 merged commit 659e925 into woodpecker-ci:main Jul 23, 2024
7 checks passed
@6543 6543 deleted the rm/WOODPECKER_DEV_GITEA_OAUTH_URL branch July 23, 2024 12:25
@woodpecker-bot woodpecker-bot mentioned this pull request Jul 23, 2024
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
…L` (woodpecker-ci#3961)

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants