-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two row layout for title and context of pipeline list #3976
base: main
Are you sure you want to change the base?
Conversation
It turns out you're ahead of me, that is cool 👍 |
Yes this looks better to me, thanks. I agree with @zc-devs, PR/branch icons are missing. Also I don't think we have a benefit from showing the PR title twice now. Can't this be done in the corresponding PR? |
Does it work on the mobile view? Can you add an example screenshot for that as well? |
Maybe we can we just show PR number before title in first row and in second only commit? |
I wouldn't do this as later, we might have both PR title and commit title. Commit title should go into the first row, but PR title in the second one (see #3421) |
I would probably do the other way around as the PR title is more likely to be more descriptive and is the primary info |
As you requested a review, there is still feedback that was not addressed yet. |
This PRs adds the two row layout for the pipeline list again to allow showing long messages and pr titles.