Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move manual popup to own page #3981

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

Screenshot 2024-07-25 at 20-38-59 Woodpecker

closes #3942
closes #3943
related #3827

@qwerty287 qwerty287 added ui frontend related refactor delete or replace old code labels Jul 25, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Jul 25, 2024
@qwerty287 qwerty287 requested a review from a team July 25, 2024 18:47
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 25, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3981.surge.sh

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.87%. Comparing base (123c4ae) to head (d3cf2d1).
Report is 2 commits behind head on main.

Files Patch % Lines
server/api/repo.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3981      +/-   ##
==========================================
- Coverage   26.89%   26.87%   -0.02%     
==========================================
  Files         394      394              
  Lines       27467    27468       +1     
==========================================
- Hits         7388     7383       -5     
- Misses      19380    19386       +6     
  Partials      699      699              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for implementing!

@pat-s pat-s enabled auto-merge (squash) August 7, 2024 07:14
@pat-s pat-s merged commit 2d1bc9f into woodpecker-ci:main Aug 7, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 6, 2024
1 task
@qwerty287 qwerty287 deleted the own-man-page branch August 7, 2024 15:36
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
3 participants