Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on InvalidImageName #4007

Merged

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Aug 5, 2024

Closes #3856

@qwerty287 qwerty287 added enhancement improve existing features backend/kubernetes labels Aug 6, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.89%. Comparing base (123c4ae) to head (8bbd634).
Report is 16 commits behind head on main.

Files Patch % Lines
pipeline/backend/kubernetes/utils.go 0.00% 7 Missing ⚠️
pipeline/backend/kubernetes/kubernetes.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4007      +/-   ##
==========================================
- Coverage   26.89%   26.89%   -0.01%     
==========================================
  Files         394      394              
  Lines       27467    27474       +7     
==========================================
  Hits         7388     7388              
- Misses      19380    19387       +7     
  Partials      699      699              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit c5746cc into woodpecker-ci:main Aug 6, 2024
8 of 9 checks passed
@zc-devs zc-devs deleted the 3856-fail-on-InvalidImageName branch August 6, 2024 15:43
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 6, 2024
1 task
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline stucks for kubernetes if image is invalid
2 participants