Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate key workflow_id in the agent logs #4046

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

hg
Copy link
Contributor

@hg hg commented Aug 16, 2024

Noticed this while studying logs in IDEA, which highlights these things:

{"level":"debug","repo":"demo/test","pipeline":"26","workflow_id":"184","image":"docker.io/woodpeckerci/plugin-git:2.5.2","workflow_id":"184","time":"2024-08-16T12:14:00Z","caller":"woodpecker/agent/logger.go:51","message":"log stream opened"}
{"level":"debug","repo":"demo/test","pipeline":"26","workflow_id":"184","image":"docker.io/woodpeckerci/plugin-git:2.5.2","workflow_id":"184","time":"2024-08-16T12:14:01Z","caller":"woodpecker/agent/logger.go:58","message":"log stream copied, close ..."}

The logger is built from another logger that already sets this field to the same value.

@6543 6543 added enhancement improve existing features skip-changelog and removed skip-changelog labels Aug 16, 2024
@6543 6543 enabled auto-merge (squash) August 16, 2024 12:58
@6543 6543 added this to the 3.0.0 milestone Aug 16, 2024
@6543 6543 merged commit 73e6b7a into woodpecker-ci:main Aug 16, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 16, 2024
1 task
@woodpecker-bot
Copy link
Collaborator

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.83%. Comparing base (289f530) to head (1828a28).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
- Coverage   26.88%   26.83%   -0.06%     
==========================================
  Files         396      394       -2     
  Lines       27465    27338     -127     
==========================================
- Hits         7384     7335      -49     
+ Misses      19376    19305      -71     
+ Partials      705      698       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants