Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema with detached steps #4066

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

xtexChooser
Copy link
Contributor

commands is optional, when detach is set.

Also fixes #4065, which made commands required (it can be unset when entrypoint is available) and therefore some schema tests fail.

For a step like:

  detached:
    image: redis
    detach: true

It matches commands_step and plugin_step at the same time, so change oneOf to anyOf.

@qwerty287 qwerty287 added bug Something isn't working schema labels Aug 29, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Aug 29, 2024
@anbraten
Copy link
Member

Could you add some tests.

@xtexChooser
Copy link
Contributor Author

There are already tests in test-step.yaml and test-dag.yaml, which are enough for these fixes.

@qwerty287 qwerty287 enabled auto-merge (squash) August 29, 2024 13:01
@qwerty287 qwerty287 merged commit e2a43e8 into woodpecker-ci:main Aug 29, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 29, 2024
1 task
@woodpecker-bot
Copy link
Collaborator

6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants