Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter secrets by plugins with specific tags #4069

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 31, 2024

This enhance the current feature.
Since tags where ignored in the past, this is still a breaking change.

@6543 6543 added enhancement improve existing features breaking will break existing installations if no manual action happens security labels Aug 31, 2024
@6543 6543 added this to the 3.0.0 milestone Aug 31, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 31, 2024

docs/docs/20-usage/40-secrets.md Outdated Show resolved Hide resolved
docs/docs/20-usage/40-secrets.md Outdated Show resolved Hide resolved
pipeline/frontend/yaml/utils/image.go Outdated Show resolved Hide resolved
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button, didn't want to approve...

6543 and others added 2 commits August 31, 2024 12:59
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@6543 6543 requested a review from qwerty287 August 31, 2024 11:03
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.88%. Comparing base (599dd97) to head (7c97e50).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4069      +/-   ##
==========================================
+ Coverage   26.84%   26.88%   +0.04%     
==========================================
  Files         394      394              
  Lines       27342    27357      +15     
==========================================
+ Hits         7340     7355      +15     
  Misses      19304    19304              
  Partials      698      698              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/docs/20-usage/40-secrets.md Outdated Show resolved Hide resolved
docs/docs/20-usage/40-secrets.md Outdated Show resolved Hide resolved
@6543 6543 merged commit fb6068d into woodpecker-ci:main Aug 31, 2024
9 checks passed
@6543 6543 deleted the add-opt-explicit-specify-tags-for-plugin-filter-at-secrets branch August 31, 2024 11:46
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 30, 2024
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
…r-ci#4069)

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens enhancement improve existing features security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants