Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alter trusted clone plugins and filter them via tag #4074

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 1, 2024

Make it possible to let an admin define privileged- and trusted-clone-plugins by name and tag.

If no tag is specified it will allow all tags as it was before.

cli/exec/exec.go Show resolved Hide resolved
@6543 6543 added the security label Sep 1, 2024
@6543 6543 changed the title Allow trusted and privileged plugins to be filtered via tag Allow trusted clone plugins to be filtered via tag Sep 1, 2024
@6543 6543 changed the title Allow trusted clone plugins to be filtered via tag Allow alter trusted clone plugins and filter them via tag Sep 1, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Sep 1, 2024

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 57.62712% with 25 lines in your changes missing coverage. Please review.

Project coverage is 26.96%. Comparing base (8e0af15) to head (4310ce4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/lint/lint.go 0.00% 7 Missing ⚠️
cli/exec/exec.go 0.00% 4 Missing ⚠️
pipeline/frontend/yaml/linter/option.go 0.00% 4 Missing ⚠️
cmd/server/setup.go 0.00% 3 Missing ⚠️
pipeline/frontend/yaml/linter/linter.go 85.71% 2 Missing and 1 partial ⚠️
pipeline/frontend/yaml/compiler/compiler.go 77.77% 1 Missing and 1 partial ⚠️
pipeline/frontend/yaml/types/container.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4074      +/-   ##
==========================================
+ Coverage   26.91%   26.96%   +0.05%     
==========================================
  Files         394      394              
  Lines       27380    27416      +36     
==========================================
+ Hits         7368     7393      +25     
- Misses      19312    19323      +11     
  Partials      700      700              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 merged commit 3c8204a into woodpecker-ci:main Sep 1, 2024
9 checks passed
@6543 6543 deleted the allow-trusted-and-privileged-plugins-to-be-filtered-via-tag branch September 1, 2024 18:41
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 1, 2024
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features security server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants