Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart tasks on dead agents sooner #4114

Merged
merged 11 commits into from
Sep 20, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 15, 2024

And run the steady queue process as background job

@6543 6543 added server enhancement improve existing features labels Sep 15, 2024
server/queue/fifo.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.96%. Comparing base (41b2127) to head (253a1a3).

Files with missing lines Patch % Lines
server/queue/fifo.go 89.65% 2 Missing and 1 partial ⚠️
agent/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
- Coverage   26.97%   26.96%   -0.02%     
==========================================
  Files         395      395              
  Lines       27406    27409       +3     
==========================================
- Hits         7393     7390       -3     
- Misses      19311    19314       +3     
- Partials      702      705       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 marked this pull request as draft September 15, 2024 22:19
@6543 6543 marked this pull request as ready for review September 16, 2024 08:21
@6543 6543 requested a review from lafriks September 16, 2024 09:01
@6543
Copy link
Member Author

6543 commented Sep 16, 2024

backport the queue fix: #4115

@6543 6543 added this to the 3.0.0 milestone Sep 16, 2024
@anbraten anbraten changed the title Restart task on ded agent sooner Restart tasks on dead agents sooner Sep 16, 2024
@6543 6543 enabled auto-merge (squash) September 20, 2024 07:31
@6543 6543 merged commit eebaa10 into woodpecker-ci:main Sep 20, 2024
6 of 7 checks passed
@woodpecker-bot
Copy link
Collaborator

@woodpecker-bot woodpecker-bot mentioned this pull request Sep 20, 2024
1 task
@6543 6543 deleted the restart-task-on-ded-agent-sooner branch September 20, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants