Change default icon size to 20 #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-s
approved these changes
Nov 26, 2024
This is mad. So when the reviewer merges main as the last person, the review isn't counted 👀 |
|
Yeah @qwerty287 was reporting this in our internal chat already. Maybe @woodpecker-ci/owner can check if we can disable it. |
|
Tearing down https://woodpecker-ci-woodpecker-pr-4458.surge.sh |
|
Lol... it was enough to add another commit to ensure the last commit was not done by the approver? And then the already existing approval is valid? GitHub, you are drunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most places, we use icons right beside text. This PR changes the default icon size to
20as this fits better with the default text size.Before:
After: