Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display system CA error only if there is an error #870

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Display system CA error only if there is an error #870

merged 2 commits into from
Apr 5, 2022

Conversation

mscherer
Copy link
Contributor

@mscherer mscherer commented Apr 5, 2022

No description provided.

@anbraten anbraten changed the title Display system CA error only if there is a error Display system CA error only if there is an error Apr 5, 2022
@anbraten anbraten enabled auto-merge (squash) April 5, 2022 12:01
@anbraten anbraten added enhancement improve existing features cli labels Apr 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #870 (f18bbcb) into master (eb6d69e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   51.76%   51.75%   -0.02%     
==========================================
  Files          80       80              
  Lines        6054     6056       +2     
==========================================
  Hits         3134     3134              
- Misses       2741     2743       +2     
  Partials      179      179
Impacted Files Coverage Δ
cli/internal/util.go 11.26% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddc54b...f18bbcb. Read the comment docs.

@anbraten anbraten merged commit 1fb8003 into woodpecker-ci:master Apr 5, 2022
@6543 6543 added this to the 1.0.0 milestone May 12, 2022
@6543 6543 added the backport-done indicates that this pull has been backported label Oct 18, 2022
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Oct 18, 2022
@mscherer @6543
Display system CA error only if there is an error (woodpecker-ci#870)
efd4801
@6543 6543 mentioned this pull request Oct 18, 2022
Merged
@6543 6543 added bug Something isn't working and removed enhancement improve existing features labels Oct 18, 2022
@6543
Copy link
Member

6543 commented Oct 18, 2022

-> #1286

6543 added a commit that referenced this pull request Oct 18, 2022
@6543 @mscherer
Display system CA error only if there is an error (#870) (#1286)
3127ba9 
Backport #870
Close #1281

Co-authored-by: mscherer <mscherer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
backport-done indicates that this pull has been backported bug Something isn't working cli
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mscherer @codecov-commenter @6543 @anbraten