docs: Rename "unsecure" to insecure #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Dec 10, 2024
docs/audits.md
Outdated
| @@ -634,7 +634,7 @@ Workflow commands (like `::set-env` and `::add-path`) | |||
| to inject environment variables and therefore obtain code execution). | |||
|
|
|||
| However, users can explicitly re-enable them by setting the | |||
| `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable at the workflow, | |||
| `ACTIONS_ALLOW_INSECURE_COMMANDS` environment variable at the workflow, | |||
There was a problem hiding this comment.
We can't change the environment variable anywhere, only the other uses of "unsecure" -- the envvar is GitHub's own misspelling, which we need to detect.
(Sorry, I didn't notice this in your search earlier.)
There was a problem hiding this comment.
Okay!
Done 🍏
We have 1×unsecure, I've added some "GitHub"-s.
woodruffw
approved these changes
Dec 10, 2024
woodruffw
changed the title
|
Glad to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269