feat: template-injection: filter static envs #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a class of false positives in the
template-injection
audit, where${{ env.foo }}
was flagged as a potential injection source despitefoo
being defined as a literal (non-expression) string in one of the workflow'senv:
blocks.More generally, there's still a group of false positives this doesn't address. For example:
This still flags
${{ env.foo }}
as an injection source, despitefoo
's value coming from a "safe" template expansion.Closes #313.