Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix Sarif schema and add rules to Sarif files #330

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat: Fix Sarif schema and add rules to Sarif files #330

merged 3 commits into from
Dec 19, 2024

Conversation

fcasal
Copy link
Contributor

@fcasal fcasal commented Dec 19, 2024

This PR

  • fixes the schema used in the sarif files
  • adds a rules section with the documentation URL
  • replaces the finding identifier with the finding description in the result's message

When viewed with the Sarif Explorer VSCode extension,
Before
image

After
image

woodruffw
woodruffw approved these changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcasal!

@woodruffw woodruffw added the enhancement New feature or request label Dec 19, 2024
@woodruffw woodruffw changed the title Fix Sarif schema and add rules to Sarif files feat: Fix Sarif schema and add rules to Sarif files Dec 19, 2024
@woodruffw woodruffw enabled auto-merge (squash) December 19, 2024 12:48
@woodruffw woodruffw merged commit f5a22cf into woodruffw:main Dec 19, 2024
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcasal @woodruffw