fix: setup-go's cache-control is OptOut

[jmelahman]

setup-go's caching is on by default and opt-out with cache=false, https://github.com/actions/setup-go?tab=readme-ov-file#v4

Fixes this false positive,

[woodruffw]

Thanks @jmelahman! I'll review this later today.

[ubiratansoares]

My bad here, @jmelahman, thank you so much for catching this one!

Too easy to get lost on those booleans when modelling the behaviour of those cache-aware Actions, I guess 🙈

If I got everything correctly, the issue is setup-go actually defines opt-in via the cache input; however the control value is actually a boolean, not a string-as-enum in as we have in setup-node, setup-java and others.

I gave a try on your Workflow locally, setting the control value to ControlValue::Boolean and it fixes the issue

I think the way to go here is moving the control value to ControlValue:Boolean, since the description of the cache input in setup-go makes it clear that true == opt-in for caching

[Edit] for the sake of a comparison, the lookup-only input* in actions/cache/restore defines the opposite semantics, i.e, true == opt-out of cache restoration.

Does that make sense?

[woodruffw]

Unless I'm misunderstanding, I think setup-go is indeed opt-out:

The action will try to enable caching unless the cache input is explicitly set to false.

(From the README)

However, I agree that this should be ControlValue::Boolean.

[woodruffw]

Oh, this was my misunderstanding -- I forgot about the distinction between CacheControl and caching_by_default. @ubiratansoares's explanation makes sense to me!

[woodruffw]

Thanks for raising this @jmelahman!