Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds unpinned-uses support to composite actions #364

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ubiratansoares
Copy link
Contributor

Contributes to #350

I tried to dedup a bit the inner logic for this audit by extracting at least one common function. I do think there is room for more deduplication, but I did not want to push hard on that in the first take.

Let me know your thoughts 🙂

@woodruffw
Copy link
Owner

Looks good to me! Feel free to dedupe here or in a follow-up, whatever you prefer 🙂

@ubiratansoares
Copy link
Contributor Author

Follow-up then, so I have room to get more used to the new CompositeStep APIs 🙂.

I'll take a self-note to revisit this one!

Copy link
Owner

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ubiratansoares!

@woodruffw woodruffw merged commit 2171f31 into woodruffw:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants