fix: Always use the plain formatter even when the output is not a terminal

[asmeurer]

Fixes #76

I was also looking at whether color support should be modified when the terminal isn't a tty. I think this can be done by enabling supports-colors in owo_colors, although I'm not really a Rust dev and I couldn't quite figure out how to get this working right https://docs.rs/owo-colors/4.1.0/owo_colors/index.html#only-style-on-supported-terminals

[woodruffw]

Thanks @asmeurer! This LGTM.

I was also looking at whether color support should be modified when the terminal isn't a tty.

This shouldn't be an issue, since we use anstream::println! to render the output and that will filter colors and other control codes when the output isn't a TTY 🙂

[asmeurer]

To be clear, I was testing out piping the output to less or to a file and the color codes were not being filtered (even when I tried using if_supports_color like in the owo docs example).

[woodruffw]

To be clear, I was testing out piping the output to less or to a file and the color codes were not being filtered (even when I tried using if_supports_color like in the owo docs example).

Huh, that's interesting -- for me locally, they get filtered when I pipe to less. Could you share the exact command you're running?

For context, I tried with both less and less -R and didn't see any colors.

[asmeurer]

I ran cargo build --release then ./target/release/zizmor on a repo, both with a pipe to less and redirecting into a file (which I confirmed with a hex editor contains the ANSI codes). I wouldn't be surprised if something went awry in my building somehow, though.

[woodruffw]

Weird. I'm at a loss to explain that -- I ran the following:

./target/debug/zizmor ~/personal/devel/gha-hazmat/ > /tmp/zizmor.txt

and opened zizmor.txt, and it's 100% plain text. I also tried with | tee /tmp/zizmor.txt | less interposed and also got plain text.

This might be a host OS thing. Are you on Windows?

[asmeurer]

I am on a Mac.

[woodruffw]

Okay, me too. I'm stumped then 🙂

[daviddavis]

FWIW, I ran:

cargo build --release
./target/release/zizmor ../gha-hazmat > /tmp/zizmor.txt

And got plain output, no json or colors.