Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitting port in server URI sets port to 0 #203

Open
mainnet-pat opened this issue Apr 18, 2024 · 4 comments
Open

Omitting port in server URI sets port to 0 #203

mainnet-pat opened this issue Apr 18, 2024 · 4 comments

Comments

@mainnet-pat
Copy link
Contributor

If I create a MoneroWalletFull with server URI without port like https://monerod.slvit.us, the fetch requests are going to be look like https://monerod.slvit.us:0/json_rpc and fail.

To work around this I need to set server to https://monerod.slvit.us:443 which is unnecessary verboe

@woodser
Copy link
Owner

woodser commented Aug 15, 2024

Fixed in monero-project/monero#9438, monero-project/monero#9439, depending on their feedback.

@mainnet-pat
Copy link
Contributor Author

This still persists. I have to explicitly specify https://node.sethforprivacy.com:443 instead of just https://node.sethforprivacy.com

@woodser
Copy link
Owner

woodser commented Aug 29, 2024

Yeah the PR to monero-project has not been merged yet, so the behavior is still consistent with monero-project.

We could apply it as a custom extension to monero-project for the libraries in the meantime, but that does come with some overhead to maintain, so it would be nice if they simply merge it. :)

@mainnet-pat
Copy link
Contributor Author

mainnet-pat commented Aug 29, 2024

Why not simply check in monero-ts if port is omitted in http(s) then explicitly add :80(:443)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants