-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omitting port in server URI sets port to 0 #203
Comments
Fixed in monero-project/monero#9438, monero-project/monero#9439, depending on their feedback. |
This still persists. I have to explicitly specify |
Yeah the PR to monero-project has not been merged yet, so the behavior is still consistent with monero-project. We could apply it as a custom extension to monero-project for the libraries in the meantime, but that does come with some overhead to maintain, so it would be nice if they simply merge it. :) |
Why not simply check in monero-ts if port is omitted in http(s) then explicitly add :80(:443)? |
If I create a
MoneroWalletFull
with server URI without port likehttps://monerod.slvit.us
, the fetch requests are going to be look likehttps://monerod.slvit.us:0/json_rpc
and fail.To work around this I need to set server to
https://monerod.slvit.us:443
which is unnecessary verboeThe text was updated successfully, but these errors were encountered: