Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https addresses use default port of 443 #9439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woodser
Copy link
Contributor

@woodser woodser commented Aug 15, 2024

No description provided.

@ndorf
Copy link
Contributor

ndorf commented Aug 16, 2024

If one wanted to be pedantic, the "proper" way to do this might be getservbyname(parsed.schema)...

@woodser
Copy link
Contributor Author

woodser commented Aug 17, 2024

If one wanted to be pedantic, the "proper" way to do this might be getservbyname(parsed.schema)...

I've updated it to use getservbyname:

if (parsed.port == 0 && (parsed.schema == "http" || parsed.schema == "https"))
{
  struct servent *serv = getservbyname(parsed.schema.c_str(), "tcp");
  parsed.port = ntohs(serv->s_port);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants