Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vite sample application [2 XMR] #229

Closed
woodser opened this issue Aug 16, 2024 · 6 comments
Closed

Fix vite sample application [2 XMR] #229

woodser opened this issue Aug 16, 2024 · 6 comments
Labels
💰bounty There is a bounty on this issue

Comments

@woodser
Copy link
Owner

woodser commented Aug 16, 2024

Currently, the vite sample application supports loading a keys-only wallet in the browser and displaying its keys.

However, http requests fail to send:

TypeError: Cannot read properties of undefined (reading 'call')
        at m.sendJsonRequest (index.js:478:11292)
        at async T.getHeight (index.js:496:42372)
        at async tA (index.js:505:106455)

And http requests fail to send within the web worker:

TypeError: r.g.fetch is not a function
        at h._onFinish (monero_web_worker.js:2:1543631)
        at e.exports.<anonymous> (monero_web_worker.js:2:1542602)
        at a.emit (monero_web_worker.js:2:1007398)

This issue requests fixing the vite sample application so it fully works with monero-ts.

@woodser woodser added the 💰bounty There is a bounty on this issue label Aug 16, 2024
Copy link

There is a bounty on this issue. The amount is in the title. The reward will be awarded to the first person or group of people who resolve this issue.

If you are starting to work on this bounty, please write a comment so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable timeframe or, in case of an extensive work, updates on their progress. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of the bounty system.

@Myestery
Copy link

I'll like to start working on this

@woodser
Copy link
Owner Author

woodser commented Aug 19, 2024

This bounty is open to the first working/merged solution.

@mainnet-pat
Copy link
Contributor

taking a look

@Myestery
Copy link

Hello @woodser
I got it to work here woodser/xmr-sample-vite#3
Had to polyfill use of request promise to axios library

@woodser
Copy link
Owner Author

woodser commented Aug 22, 2024

This issue is resolved with #230 in the v0.10.1 release, and https://github.com/woodser/xmr-sample-vite.

@woodser woodser closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰bounty There is a bounty on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants