Polyfill with axios #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample usage 
|
|
@woodser were you able to take a look? |
|
This solution from mainnet-pat gets us very close by simply adding "stream" as a node polyfill: #2 The only remaining issue should be resolved by updating the request and request promise dependencies, hopefully avoiding the need for axios polyfill. |
|
This issue was resolved by switching monero-ts to use Axios instead of the deprecated request libraries: woodser/monero-ts#230, #4 Thanks for your effort though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix woodser/monero-ts#229
Request-Promise and Request libraries are deprecated so I polyfilled with axios to escape using them
A more permanent solution will be to rewrite the implementation in monero-ts to use something like axios