Refactor to use .env for node and wallet-rpc config #11
+240
−2,202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html: Add no-cache headers - placeholder for daemon info WIP: replace hardcoded with env values Ignore npm/pnpm lock-files Add more .env variables
- add curl node test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I don't have anything running on
localhost, these changes are what's needed for my environment.Monero stuff,
monerodandwallet-rpcare running on one host.I had to proxy wallet-rpc, as it does not respond well to preflight
OPTIONSrequests.Proxy:
https://proxy.domain.tld/rpc/portAnother host is for development, and are serving this thing as a website:
https://www.domain.tldThe test runs successfully in all 3 variations.
pnpm dev,pnpm startand served by Apache fromdistdirectory.Let me know what you think.