Use public API in derive_circuit only
#2
Conversation
|
@Cryoris Thanks, this is better than the fix I had which still used private access in the newer alternate path. Lets go with this then. I am trying to figure your comment in the PR to algos from the branch this targets. I am ok with merging this now to the PR to algs since this avoids any private access. Then as regards that PR I wanted to wait at least until Jakes PR was merged to main so I could drop that data copy workaround. Once that was done and the PR passed I figured it could be merged. If something else came up then it could be fixed later - otherwise that PR in main should get backported for 1.2 right. And once 1.2 is released this will then properly test against that as I am not sure, given that stable 1.2 branch has been already created, how much main is diverging, if any yet, from that prepared stable branch. |
|
(so far 1.2 should not diverge from main more than 1 or 2 PRs, all PRs tagged for 1.2 are merged to main and then backported to 1.2) |
Summary
Qiskit/qiskit#12794 fixes the faulty behavior requiring the copy of
circuit.data, but breaks other parts of the gradients that use the private_parameter_table. This PR uses only public API function to avoid breaking in this way in the future.