Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Psr\Http\Client\ClientInterface as type #33

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

holtkamp
Copy link
Contributor

As suggested in #32

@holtkamp
Copy link
Contributor Author

@kocsismate I encountered this PR, could you consider merging it?

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #33 (58ac40e) into master (8d48ee7) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 58ac40e differs from pull request most recent head 7c78944. Consider uploading reports for the commit 7c78944 to get more accurate results

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     97.92%   97.92%           
  Complexity      514      514           
=========================================
  Files            29       29           
  Lines          1060     1060           
=========================================
  Hits           1038     1038           
  Misses           22       22           
Files Changed Coverage Δ
src/JsonApi/Client/JsonApiClient.php 0.00% <0.00%> (ø)

@holtkamp
Copy link
Contributor Author

holtkamp commented Aug 8, 2023

@kocsismate subtle but shameless bump?

@kocsismate
Copy link
Member

@holtkamp OK, I'll try to find some time in the following days to merge your PR and release a new major version!

@kocsismate kocsismate merged commit 70a8166 into woohoolabs:master Aug 14, 2023
9 checks passed
@holtkamp holtkamp deleted the psr-18 branch August 22, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants