Fix Next by using default import for CJS #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using named imports was rendering an error when using with Next.js and mdx-bundler, the following change fixes the problem
ChristianMurphy
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
It makes sense for the currently version range https://unpkg.com/mdast-util-mdx@0.1.0/index.js
An alternative could be updating
Line 49 in 30033e6
^1.0.0which is pure ESM and has no default export https://github.com/syntax-tree/mdast-util-mdx/blob/b27dc8aa3ff340815b5f04f15ee1e6ed3a753a79/index.js#L13-L23
wooorm
reviewed
Jul 29, 2021
There was a problem hiding this comment.
- This is an error in Next + webpack et al, which you could perhaps report there. While CJS handling is non-standard, I believe users are right to expect Next/webpack to work the same as Node for CJS in ESM.
- I’m not sure whether the next version of
mdast-util-mdxalready works, it might expect a couple of updates in micromark/mdast/remark/unified, so we should probably wait a little bit before remark is updated pkgis a bit of a vague name, and the code style doesn’t match this project: here’s what I suggest, but you can also check these things locally by runningnpm test
Co-authored-by: Titus <tituswormer@gmail.com>
wooorm
approved these changes
Jul 30, 2021
wooorm
changed the title
|
Released in 1.12.2! https://github.com/wooorm/xdm/releases/tag/1.12.2 |
danielolaviobr
added a commit
to danielolaviobr/mdx-bundler
that referenced
this pull request
Jul 30, 2021
Update xdm to patch the default import error, as explained in the following (PR)[wooorm/xdm#73]
3 tasks
kentcdodds
pushed a commit
to kentcdodds/mdx-bundler
that referenced
this pull request
Jul 30, 2021
Update xdm to patch the default import error, as explained in the following (PR)[wooorm/xdm#73]
Kusou1y1
added a commit
to Kusou1y1/kentcdoddsl
that referenced
this pull request
Dec 8, 2021
Update xdm to patch the default import error, as explained in the following (PR)[wooorm/xdm#73]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using named imports was rendering an error when using with Next.js and mdx-bundler, the following change fixes the problem