Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notice "Undefined offset: 2", add support Bing Optimized IE #9

Closed
wants to merge 2 commits into from
Closed

fix notice "Undefined offset: 2", add support Bing Optimized IE #9

wants to merge 2 commits into from

Conversation

k-holy
Copy link
Contributor

@k-holy k-holy commented Jul 10, 2014

"Notice: Undefined offset: 2" in Woothee\AgentCategory\Browser\Msie.php on line 17

MSIE11 (Bing Optimized) + Windows 7
Mozilla/5.0 (Windows NT 6.1; Trident/7.0; BOIE9;JAJP; rv:11.0) like Gecko

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a0987d3 on k-holy:fix-browser-msie into eaf7eaa on woothee:master.

@yuya-takeyama
Copy link
Member

寿司ゆき:thanks
Merged.
I manually merged woothee/woothee#8 on my local environment, and confirmed your patch works wine.

yuya-takeyama added a commit to woothee/woothee-ruby that referenced this pull request Jul 10, 2014
xmas7 pushed a commit to RubyOnWorld/woothee-ruby that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants