Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support Python3.4 #16

Merged
merged 9 commits into from
Aug 8, 2019
Merged

drop support Python3.4 #16

merged 9 commits into from
Aug 8, 2019

Conversation

hhatto
Copy link
Member

@hhatto hhatto commented Jul 28, 2019

why

In my opinion, basically there is no reason to actively use Python 2.7 and 3.4, and I want to support it because using the latest pytest (version 5.x) also fails the test.

change summary

  • changed to not run python 3.4 tests
  • change from PyPy(2.x) to PyPy3.5 on test

@hhatto hhatto requested a review from tell-k August 8, 2019 01:57
Copy link
Member

@tell-k tell-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhatto LGTM!

Sorry for the late reply.
Thank you for your contribution :)

@tell-k tell-k merged commit 09967e7 into woothee:master Aug 8, 2019
@hhatto hhatto deleted the fix-fail-test branch August 8, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants