Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat#159/대기열 로직에 티켓 판매 시각 검증 및 티켓팅 진행할 티켓 관리 로직 추가 #163

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

minnim1010
Copy link
Collaborator

📄 작업 설명

  • 대기 순서를 발급하거나 대기 순서를 조회할 때, 티켓 판매 시각을 검증하는 로직을 추가했습니다.
  • 티켓팅을 진행할 티켓을 redis에 저장하고, 티켓팅 진행 중인 모든 티켓 입장 순서 범위를 갱신하는 로직을 추가했습니다.

🚨 관련 이슈

🌈 작업 상황

  • 대기열 로직에서 티켓이 존재하는지, 티켓의 판매 시각인지 검증하는 로직 추가
  • 티켓팅 진행할 티켓을 티켓팅 전 redis에 저장하는 로직 추가
    • 규원님의 feat#147(mysql 티켓 메타데이터 동기화 스케줄링 로직)에 포함시켜 구현했습니다.
  • 티켓팅 진행하는 티켓들의 입장 순서 범위를 스케줄링으로 갱신하는 로직을 추가
    • 5초 주기로 현재 진행 중인 모든 티켓팅들의 티켓 id를 가져와 입장 순서 범위를 갱신합니다.

📌 기타

@minnim1010 minnim1010 added the 기능 New feature or request label Aug 29, 2024
@minnim1010 minnim1010 requested a review from a team August 29, 2024 01:34
@minnim1010 minnim1010 self-assigned this Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for twodari canceled.

Name Link
🔨 Latest commit 71f5490
🔍 Latest deploy log https://app.netlify.com/sites/twodari/deploys/66cfd3bde4dd3000087482f9

Copy link

github-actions bot commented Aug 29, 2024

Risk Level 2 - /home/runner/work/Team2-Dari/Team2-Dari/backend/k6-monitoring/scripts/wait-event-test.js

  1. The addition of the getQueuePosition function is a good enhancement for polling queue status. Ensure that it handles potential errors gracefully. 2. The use of sleep for polling is acceptable, but consider implementing a more robust polling mechanism if the wait times are significant.

Risk Level 2 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/ticket/service/TicketScheduleService.java

  1. The addition of the updateRedisCurrentTicketWait method is a good enhancement for tracking current ticket waits. Ensure that the method is tested adequately to avoid runtime issues. 2. Consider using a more descriptive name for createUpdateRedisTicketCronTrigger to improve readability.

Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/queue-server/src/main/java/com/wootecam/festivals/domain/wait/service/WaitOrderService.java

  1. The new methods for validating ticket sale time and stock remain are good additions. Ensure that they are thoroughly tested to avoid runtime exceptions. 2. The logic for handling wait orders is complex; consider adding comments to clarify the flow for future maintainers.

🛠️📈📝


Powered by Code Review GPT

Copy link

github-actions bot commented Aug 29, 2024

Code Coverage Report

Overall Project 88.88% -0.22% 🍏
Files changed 95.28% 🍏

Module Coverage
queue-server 95.9% -2.05% 🍏
api-server 88.04% 🍏
Files
Module File Coverage
queue-server PassOrderRedisRepository.java 97.4% -2.6% 🍏
WaitOrderService.java 96.97% -3.03% 🍏
WaitErrorCode.java 87.91% 🍏
api-server TicketScheduleService.java 96.43% 🍏

@minnim1010 minnim1010 merged commit 7e6af60 into develop Aug 29, 2024
7 checks passed
@minnim1010 minnim1010 deleted the feat#159 branch August 29, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 대기열 로직에 티켓 판매 시각 검증 및 티켓팅 진행할 티켓 관리 로직 추가
2 participants