Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cross-env 패키지 추가 및 적용 (#39) #40

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

Puterism
Copy link
Collaborator

@Puterism Puterism commented Jul 8, 2021

  • Windows 환경에서 NODE_ENV를 사용할 수 있도록 cross-env 패키지를 추가하고 적용함.

Close #39

@Puterism Puterism self-assigned this Jul 8, 2021
Copy link
Collaborator

@yujo11 yujo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac에서도 정상 동작하는거 확인 했습니다! 고생하셨습니다!! 👍👍👍

@Puterism Puterism merged commit 7144944 into dev Jul 8, 2021
@Puterism Puterism deleted the 39-cross-env branch July 8, 2021 10:17
Puterism added a commit that referenced this pull request Jul 9, 2021
Puterism added a commit that referenced this pull request Jul 12, 2021
* chore: `cross-env` 패키지 추가 및 적용 (#40)

* feat: Panel 컴포넌트 구현

* refactor: 배경색에 따라 색이 정해지는 스타일 정의를 분리

- 텍스트 색에 적용되는 `responsiveTextColor` 정의
- SVG fill 속성에 적용되는 `responsiveFill` 정의
- 공통적으로 적용할 수 있는 `ResponsiveColorProps` interface 정의

* refactor: `Panel` 컴포넌트에 `onToggle` prop 추가

* fix: ESLint가 올바르게 동작하지 않는 문제 수정 (#70) (#72)

* chore: `prettier` 관련 ESLint plugin 및 config 설치 및 적용

* chore: `.gitignore`에 `.eslintcache` 추가

* fix: `ESLint` warning 및 error이 발생하는 코드 수정

* refactor: `Panel` 컴포넌트가 `expanded` 상태를 가지도록 수정

- `expanded` prop을 `initialExpanded`로 이름 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] cross-env 패키지 추가 및 적용
3 participants