-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 모바일에서 에디터 페이지에 접속했을 때 안내 메세지를 보여주는 기능 #720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MobileRedirect -> EditorMobileView
yujo11
changed the title
feat: 모바일 화면에서 접속했을 때
feat: 모바일에서 에디터 페이지에 접속했을 때 안내 메세지를 보여주는 기능
Oct 28, 2021
- notFound img -> gray-logo img - EditorMobileView -> EditorOverlay
Puterism
previously approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Gary -> Gray
Puterism
approved these changes
Oct 28, 2021
SunYoungKwon
approved these changes
Oct 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
논의하고 싶은 내용
1. 네이밍
현재
EditorMobieView
라는 컴포넌트를 만들어서 보여주고 있는데 네이밍이 썩 마음에 들지 않습니다... 혹시 좋은 이름 있으면 제안해주시면 감사하겠습니다ㅠㅠ2. width 조정
기존에 얘기한 900px을 기준이 너무 큰거 같아 기준을 752px로 재조정 하였습니다.
공유하고 싶은 내용
동작
Close #714